-
Notifications
You must be signed in to change notification settings - Fork 126
Azure Wrapper #54
Azure Wrapper #54
Conversation
Thanks! A few things before this can proceed:
|
RE: Documentation. Is it ok to add links to the core fine-uploader areas? I'll add my working example as well. |
Please do link to any areas that you feel are useful. But it should at least follow the same format & tone as the existing S3 and Traditional sections in the readme. |
Is this sufficient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good to me. Are you already using these changes in your app?
@@ -39,6 +39,7 @@ These wrap a Fine Uploader instance for use in React Fine Uploader. They provide | |||
- [Installing](#installing) | |||
- [Wrapper Classes](#wrapper-classes) | |||
- [S3](#s3) - upload files to directly to an Amazon Simple Storage Service (S3) bucket. Your server must sign requests using a private key. | |||
- [Azure](#azure) - upload files directly to Azure storage |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I've updated the order. RE use: It's not fully integrated and in production yet. But, it works well in our PoC. Could it be released as |
I think this can go out at 0.3.0 since 0.x.x already let developers know that this library is not yet stable. Thanks for your work on this. Can you also add a link to the Azure feature page in the docs, similar to what I have done with the S3 section? |
Updated the docs to include the azure feature page info and also included the server examples as well. |
Awesome! Are you interested in becoming a collaborator on this project? |
@@ -0,0 +1,14 @@ | |||
import BaseWrapper from './base-wrapper' | |||
import qq from 'fine-uploader/lib/core/azure' | |||
import { traditional as callbackNames } from './callback-names' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Awesome 🎉 Thanks for merging. I'm happy to help where I can especially regarding azure specific things and I'll let you know if we have any issues in prod |
This seems to work for me and resolves issue #3