Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Azure Wrapper #54

Merged
merged 4 commits into from
Dec 13, 2016
Merged

Azure Wrapper #54

merged 4 commits into from
Dec 13, 2016

Conversation

tgandrews
Copy link
Contributor

This seems to work for me and resolves issue #3

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2016

CLA assistant check
All committers have signed the CLA.

@rnicholus
Copy link
Member

rnicholus commented Dec 9, 2016

Thanks! A few things before this can proceed:

  • Documentation updates to the README.md file, similar to the S3 & Traditional sections.
  • Can you post here specifics about your Azure setup, or at least your client-side code? I'm a bit more careful with Azure-related updates since I don't use Azure myself.
  • We'll need to release a new version, but I'll take care of that myself last.

@rnicholus rnicholus added this to the 0.3.0 milestone Dec 9, 2016
@tgandrews
Copy link
Contributor Author

RE: Documentation. Is it ok to add links to the core fine-uploader areas? I'll add my working example as well.

@rnicholus
Copy link
Member

Please do link to any areas that you feel are useful. But it should at least follow the same format & tone as the existing S3 and Traditional sections in the readme.

@tgandrews
Copy link
Contributor Author

Is this sufficient?

Copy link
Member

@rnicholus rnicholus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me. Are you already using these changes in your app?

@@ -39,6 +39,7 @@ These wrap a Fine Uploader instance for use in React Fine Uploader. They provide
- [Installing](#installing)
- [Wrapper Classes](#wrapper-classes)
- [S3](#s3) - upload files to directly to an Amazon Simple Storage Service (S3) bucket. Your server must sign requests using a private key.
- [Azure](#azure) - upload files directly to Azure storage

This comment was marked as spam.

@tgandrews
Copy link
Contributor Author

tgandrews commented Dec 12, 2016

I've updated the order.

RE use: It's not fully integrated and in production yet. But, it works well in our PoC. Could it be released as -beta?

@rnicholus
Copy link
Member

I think this can go out at 0.3.0 since 0.x.x already let developers know that this library is not yet stable. Thanks for your work on this. Can you also add a link to the Azure feature page in the docs, similar to what I have done with the S3 section?

@tgandrews
Copy link
Contributor Author

Updated the docs to include the azure feature page info and also included the server examples as well.

@rnicholus
Copy link
Member

Awesome! Are you interested in becoming a collaborator on this project?

@@ -0,0 +1,14 @@
import BaseWrapper from './base-wrapper'
import qq from 'fine-uploader/lib/core/azure'
import { traditional as callbackNames } from './callback-names'

This comment was marked as spam.

This comment was marked as spam.

@rnicholus rnicholus merged commit 5a8807c into FineUploader:master Dec 13, 2016
rnicholus added a commit that referenced this pull request Dec 13, 2016
Also prepare for 0.3.0 release.
#3
#54
@tgandrews tgandrews deleted the feature/azure-wrapper branch December 13, 2016 09:48
@tgandrews
Copy link
Contributor Author

Awesome 🎉

Thanks for merging. I'm happy to help where I can especially regarding azure specific things and I'll let you know if we have any issues in prod

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants